-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor changes to the new exp config forms #1251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seem like sensible formatting changes
@becky-gilbert Thanks for the updates. I you want, you can always ask for these changes in the original PR. I never mind making these small changes or at least talking about them. Once I get the other PR into develop, I'll rebase this and get it in as well. |
eab2f69
to
9093114
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR includes some suggested minor changes to the new separate "Study Ad" and "Study Details" forms (#1244):
studies/templates/studies/experiment_runner/base.html
I put the content inside of adiv
with therow
class so that the spacing between the content and breadcrumbs matches that in other pages (studies/templates/studies/study_edit.html
,studies/templates/studies/study_create.html
).Study details - before:
Study details - after changes in this PR:
Study ad (not changed, just for reference):
Also tagging @mekline for review of these changes, since some of my suggestions might contradict her requests.